apple / apple/swift-nio-http2

Reconsider implementation of Equatable and Hashable for HPACKHeaders

Open
#342 2 comments 0 reactions 0 assignees View on GitHub
kind/bug
Dominant language
Swift
Stars
503
Forks
103
Avg merge
18h 8m
Merged PRs (30d)
4

Description

For historical reasons, HPACKHeaders does not pay attention to order or indexability when considering equality and hashability. We should consider whether this is appropriate for this type, or whether we should make the definition more strict.

Contributor guide

Open the contributing guide

Research direction

Start by locating HPACKHeaders and reviewing its Equatable and Hashable implementations. Examine how equality currently treats header order and indexability, then review the existing issue discussion before proposing a stricter definition. Done requires an agreed semantic definition and corresponding implementation and test changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
networking
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.