apple / apple/swift-nio-http2

Remove deprecated stream channel functionality

Open
#220 0 comments 0 reactions 0 assignees View on GitHub
⚠️ semver/major
Dominant language
Swift
Stars
503
Forks
103
Avg merge
18h 8m
Merged PRs (30d)
4

Description

In #214 we deprecated and replaced the old stream channel. When we do a 2.0.0 release, we should remove the old code paths, reducing binary size, compile time, and resolving some minor performance problems.

- [ ] Remove the deprecated multiplexers and all tests that reference them.
- [ ] Remove the genericism from `HTTP2StreamChannel`, as it’s no longer necessary.
- [ ] Remove the extra code paths from `MultiplexerAbstractChannel`: it can concretely hold a single `HTTP2StreamChannel`
- [ ] Remove the initializers and code paths in `HTTP2StreamMultiplexer` that are deprecated or no-longer called
- [ ] Remove all deprecated pipeline helpers.

Contributor guide

Open the contributing guide

Research direction

Start by locating the deprecated multiplexers and the tests that reference them, then inspect HTTP2StreamChannel, MultiplexerAbstractChannel, HTTP2StreamMultiplexer, and the deprecated pipeline helpers. Use the checklist to trace each obsolete initializer and code path, and run the affected test suite and build checks after removal. Done means the deprecated functionality and its tests are gone without breaking the remaining HTTP/2 implementation.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
networking
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.