apple / apple/swift-distributed-actors

Cluster: Harsh tests for "down node, yet it extends an handshake back"

Open
#355 0 comments 0 reactions 0 assignees View on GitHub
t:cluster:all t:tests
Dominant language
Swift
Stars
679
Forks
84
PR merge metrics
No merged PRs in 30d

Description

Our .down-ing moves a UniqueNode into the Tombstones set in the ClusterShell.

When we get new handshakes we MUST ensure that the node wasn't already tombstoned -- this would make us reopen a connection to a node we downed, breaking our promises "to never talk to it again".

Contributor guide

Open the contributing guide

Research direction

Start by locating ClusterShell, the .down-ing path for UniqueNode, and the Tombstones set, then trace how new handshakes are accepted. Add focused tests for a downed node sending a handshake and verify that it remains tombstoned and no connection is reopened.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
distributed-systems, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.