apple / apple/swift-algorithms

Conditionally conform Chain2Sequence to MutableCollection

Open
#217 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
6.3k
Forks
483
PR merge metrics
No merged PRs in 30d

Description

Is there a specific reason why Chain2Sequence does not conform to `MutableCollection` when `Base1` and `Base2` do?

I'm trying to build an API that uses two `some MutableCollection` as parameters and one as return value. I need it to be mutable, because I need to change a specific element in the collection. Internally, the parameters will be chained using `chain(_:_:)` - or at least that's the goal.

I'm happy to provide a PR for this, but I wanted to see if there's a reason against it first.

Contributor guide

Open the contributing guide

Research direction

Locate Chain2Sequence and chain(_:_:), then compare their collection conformances with those of Base1 and Base2. Check Swift’s conditional MutableCollection requirements and existing collection tests; done when the reason for the current behavior and the expected mutability outcome are established.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
devtools
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.