apple / apple/servicetalk

do[On|Before|After] to use Supplier<..>

Open
#320 7 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Java
Stars
1k
Forks
229
Avg merge
23h 23m
Merged PRs (30d)
16

Description

We have operators that allow for invocation of `Consumer`s and `Runnable`s at different points in the life cycle of a `Subscription`/`Subscriber`. Most of these methods do not take a `Supplier` and that means if the corresponding `Consumer` or `Runnable` intended to have state per-`subscribe` they will not be able to easily do so correctly. We should consider if updating these methods to require a `Subscriber` makes sense.

`DoBeforeFinallyOnHttpResponseOperator` is another operator that shares the same issue.

https://github.com/servicetalk/servicetalk/pull/319#discussion_r

Contributor guide

Open the contributing guide

Research direction

Start with the discussion linked from PR #319, then inspect the do[On|Before|After] operators and DoBeforeFinallyOnHttpResponseOperator mentioned in the issue. Determine which Consumer and Runnable APIs need Supplier-based state per subscription, and confirm the intended scope and completion criteria in the discussion.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend, networking
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.