apple / apple/servicetalk

Reconsider how users use offloadNone strategy while some filters block

Open
#2,189 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
1k
Forks
229
Avg merge
23h 23m
Merged PRs (30d)
16

Description

Existing approach is that if users specify `offloadNone()` execution strategy on the builder, we respect that and disable offloading. However, if they have a filter that for sure has blocking code, it will hurt users if we are silent about it. Consider the following improvement options:
- still add offloading based on the filter chain requirements and log that the computed value is different from what was specified;
- throw an exception describing what filter does not allow using `offloadNone()`
- keep the offloading disabled, but warn users that they have a blocking code in the filter chain

Contributor guide

Open the contributing guide

Research direction

Start at the builder's offloadNone() handling and the filter-chain blocking requirement calculation. Compare the three behavior options described in the issue, including how users would be informed when blocking filters are present. Done means selecting and implementing a clear, documented behavior for this combination.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
networking
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.