apple / apple/servicetalk

TestPublisher should notice invalid re-use after termination

Open
#1,733 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
1k
Forks
229
Avg merge
23h 23m
Merged PRs (30d)
16

Description

As noticed by @ idelpivnitskiy: in `RoundRobinLoadBalancerTest` the `serviceDiscoveryPublisher` is completed but later `onNext` is invoked. It violates the spec. `TestPublisher` should validate such misuse and the tests should create a new publisher.

Contributor guide

Open the contributing guide

Research direction

Start by reading TestPublisher and RoundRobinLoadBalancerTest, especially the serviceDiscoveryPublisher lifecycle. Confirm how termination is represented and where a later onNext is currently accepted. Done means invalid reuse after termination is detected and the affected tests create a new publisher instead.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.