apple / apple/servicetalk

Re-evaluate usage of addSuppressed

Open
#168 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
1k
Forks
229
Avg merge
23h 23m
Merged PRs (30d)
16

Description

> discussed offline with @NiteshKant ... I think we should re-evaluate our usage of addSuppressed. In the face of static exceptions and addSuppressed may throw if the exception is the same instance this creates potentially undesirable behavior at the benefit of "maybe providing more context".

Originally raised here: https://github.com/servicetalk/servicetalk/pull/131#discussion_r232133741

Contributor guide

Open the contributing guide

Research direction

Start by reading the discussion linked from pull request 131, especially the referenced comment, and inspect the repository's usage of addSuppressed. The issue does not identify affected files, tests, or a decided replacement, so the completed work would first require agreeing on the intended usage and then updating all relevant cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
networking
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.