apple / apple/password-manager-resources

Sorting of subdomains question

Open
#552 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
4.8k
Forks
649
Avg merge
9h 50m
Merged PRs (30d)
15

Description

I'm working on resolving #550 right now, and I was just going to add it and use JSON sort in Boop, but I notice that would catch subdomains like this that are sorted under `P`, not `A`. : https://github.com/apple/password-manager-resources/blob/acd0159e01aef28a926fcca05e75e3f2f4183cc3/quirks/password-rules.json#L494

Similarly, this quirk is sorted under `A`, not `D`:
https://github.com/apple/password-manager-resources/blob/acd0159e01aef28a926fcca05e75e3f2f4183cc3/quirks/password-rules.json#L50

Which would be the intended sort order here, site domain (app.foo.com being sorted in `F`), or the JSON key as in the file (app.foo.com being sorted in `A`)?

Contributor guide

Open the contributing guide

Research direction

Review quirks/password-rules.json at the two linked entries and read issue #550 for the sorting change that prompted this question. Determine whether ordering should use the full JSON key or the site domain, then record the decision and apply a consistent ordering if the related work proceeds.

Written by the indexing model from the issue text.

Assessment

Tech stack
json
Domain
security
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.