apple / apple/foundationdb

Simulation crashes when compiled without NDEBUG

Open
#965 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
16.7k
Forks
1.6k
Avg merge
1d 20h
Merged PRs (30d)
126

Description

Removing `-DNDEBUG=1` from `CFLAGS` results in failed simulation tests.

Oddly, I don't actually much in our code that depends on `NDEBUG`, and we use our own `ASSERT()` macro rather than `assert()`. But the crashes are still there regardless. ‾\\\_(ツ)\_/‾

Contributor guide

Open the contributing guide

Research direction

Reproduce the simulation test failures after removing -DNDEBUG=1 from CFLAGS, then compare the failing behavior with and without NDEBUG. Start by tracing the crash through the simulation tests and the project's ASSERT() macro. Done means the simulation tests pass when compiled without NDEBUG.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
distributed-systems, testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.