txnCommitErrors should not include "illegal_tenant_access"
Open
- Dominant language
- C++
- Stars
- 16.7k
- Forks
- 1.6k
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 126
Description
In `status json`, we report ``cluster.workload.operations.memory_errors`` to measure the number of requests rejected by the proxies because the memory limit has been exceeded, which includes `TxnCommitErrors`, `KeyServerLocationErrors`, and `TxnRequestErrors`. All of them are based on memory usage.
So I think the code here:
https://github.com/apple/foundationdb/blob/c4c6aebde5cc2fe90f2adb6d2ad0eb4e18d0856b/fdbserver/CommitProxyServer.actor.cpp#L398-L402
should be modified to not counting tenant errors as part of `txnCommitErrors`.
Contributor guide
Assessment
This issue has not been assessed yet.