apple / apple/foundationdb

crc32 feature testing for ppc64le

Open
#6,577 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
16.7k
Forks
1.6k
Avg merge
1d 20h
Merged PRs (30d)
126

Description

We have recently added ppc64le support [(https://github.com/apple/foundationdb/pull/6384)](url) and the same is merged with upstream.
Now we are adding a crc32_vpmsum feature [(https://github.com/antonblanchard/crc32-vpmsum)](url) for the same.
Integrated required files(crc32.S, crc32_wrapper.c, crc32_cosntants.h, ppc-opcode.h) /code(wrapper function- crc32_vpmsum() call inside foundationDb) to get the crc32_vpmsum feature tested.
currently, we are unable to find a suitable test case in existing tests to validate the changes.
kindly guide for the same.

for more reference, attached is a system config screenshot on which we are trying to execute.
![config](https://user-images.githubusercontent.com/99784213/157615203-d11f3dc6-b355-4019-ab36-db1254e6980a.png)

Contributor guide

Open the contributing guide

Research direction

Start by reading the integrated crc32.S, crc32_wrapper.c, crc32_cosntants.h, and ppc-opcode.h files and the crc32_vpmsum() wrapper call; inspect existing FoundationDB tests for a suitable validation path. Done means identifying and adding a test that exercises the ppc64le CRC32 feature and confirms the expected result.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, cpp
Domain
databases, testing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.