apple / apple/foundationdb

Confusing behavior of no-wait exclude when a process is not reporting to the cluster

Open
#5,871 4 comments 1 reaction 1 assignee Claimed by @spraza View on GitHub
operations
Dominant language
C++
Stars
16.7k
Forks
1.6k
Avg merge
1d 20h
Merged PRs (30d)
126

Description

When running the `exclude no_wait` command with a process that is not reporting to the database, the CLI reports a message of the form: `WARNING: Missing from cluster! Be sure that you excluded the correct processes before removing them from the cluster!`. It reports the same message whether the address is completely unknown to the database, or whether it is a process that is associated with data that has not been fully re-replicated. This means that we cannot use the output of `exclude no_wait` to determine if the re-replication for that process has completed. This makes it difficult to determine if it is safe to permanently destroy resources associated with a process that is temporarily unavailable. By comparison, the blocking form of the `exclude` command will block when a process is in this state, until the data is replicated. I think we should change this behavior to give a clearer signal on processes that are missing but have data, and align the no-wait exclude and the blocking exclude more.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.