apple / apple/foundationdb

fdbcli snapshot command does not work with RocksDB

Open
#5,155 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
16.7k
Forks
1.6k
Avg merge
1d 20h
Merged PRs (30d)
126

Description

The fdbcli snapshot command takes a filesystem snapshot as a way to backup FDB by copying the files on disk. The snapshot is not atomic across multiple files, so the snapshot can end up with corrupt RocksDB files due to compaction. The RocksDB snapshot command should be used instead.

Contributor guide

Open the contributing guide

Research direction

Start by locating the fdbcli snapshot command and the code path that handles RocksDB. Compare its current filesystem-copy behavior with the intended RocksDB snapshot command, then verify that snapshots remain usable during compaction and that the relevant command behavior is covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
cli, databases
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.