apple / apple/foundationdb

Disk space for excluded storage servers should not affect ratekeeper

Open
#4,443 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
16.7k
Forks
1.6k
Avg merge
1d 20h
Merged PRs (30d)
126

Description

If a storage server has reached 95% disk space capacity, ratekeeper will heavily throttle. However, the disk space usage for an excluded storage server will not continue to grow, being at 95% disk space capacity should not affect ratekeeper. If a single storage process reaches 95% capacity, currently we have to kill the process, but we should be able to simply exclude it to prevent ratekeeper throttling.

Contributor guide

Open the contributing guide

Research direction

Start by tracing how ratekeeper uses storage-server disk capacity and how excluded storage servers are represented. Reproduce the 95% capacity scenario with an excluded server and verify that ratekeeper no longer throttles because of it, while a non-excluded server still does.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
databases, distributed-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.