apple / apple/foundationdb

Changing the version tag format or consider an additional tag for each release

Open
#4,431 4 comments 1 reaction 1 assignee Claimed by @ammolitor View on GitHub
Dominant language
C++
Stars
16.7k
Forks
1.6k
Avg merge
1d 20h
Merged PRs (30d)
126

Description

This request is regarding this particular issue with how the way we format the release version affects the Go bindings
https://github.com/apple/foundationdb/issues/3338#issuecomment-787210479

I believe the issue can be solved by tagging the release as, say , `v6.2.30` instead of `6.2.30` - an extra letter `v` before the version number. This will allow `go modules` to understand the version as really 6.2.30 instead of assuming it as 0.0.0 . I believe this is also the default format in github.

> Tagging suggestions
> It’s common practice to prefix your version names with the letter v. Some good tag names might be v1.0 or v2.3.4

If the change would break some other fdb build/release process, would you be open to addition an additional `vM.m.p' tag for each release? This may also be the easiest way to test if this would fix the issue.

Thanks

--

Hari

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.