apple / apple/foundationdb

wrap git dependencies in cmake toggles

Open
#4,184 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
16.7k
Forks
1.6k
Avg merge
1d 20h
Merged PRs (30d)
126

Description

Using current master, c895049 , since 6.3.9 there are a number of dependencies
that try to fetch code at build time. As FreeBSD ports system blocks network access
during build phase, I'd like to wrap these in something like:

```
if(NOT WITHOUT_FLOWBENCH)
...
endif()
```

Which should allow whatever existing CI / docker stuff to run without change, and allow downstream packagers to work around this. Would these be acceptable?

- [x] flowbench - simply patched it out at present
- [x] doctest - patched out as I haven't found a recipe to get FDB to find and use existing doctest port
- [x] toml11 - resolved by adding toml11 as a port

If so, I'll do a PR with doctest & flowbench toggles.

Contributor guide

Open the contributing guide

Research direction

Locate the CMake dependency setup for flowbench, doctest, and toml11, then inspect how the existing CI and Docker builds invoke it. Done means FreeBSD-style network-restricted builds can disable the relevant fetches through toggles while the default CI and Docker behavior remains unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp, git
Domain
build-system
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.