apple / apple/foundationdb

Avoid fast spin storage recruitment on storage server with bad disk

Open
#414 1 comment 0 reactions 0 assignees View on GitHub
data distribution
Dominant language
C++
Stars
16.7k
Forks
1.6k
Avg merge
1d 20h
Merged PRs (30d)
126

Description

If a host has a bad disk that prevents the kv-store files from being opened (e.g. with file_not_found errors), then the storage server can repeatedly die and be re-recruited in a tight loop. We should avoid doing this so quickly one after the other if it’s repeatedly failing.

Contributor guide

Open the contributing guide

Research direction

Start by tracing storage-server recruitment and the kv-store file-open failure path described in the issue. Review how repeated failures trigger re-recruitment and determine how to prevent a tight loop. Done means a storage server with an unusable disk does not repeatedly die and get recruited in rapid succession.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
databases, distributed-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.