apple / apple/foundationdb

Skipping call to generate default machine ID when it's not required

Open
#4,022 0 comments 0 reactions 1 assignee Claimed by @sfc-gh-mpilman View on GitHub
Dominant language
C++
Stars
16.7k
Forks
1.6k
Avg merge
1d 20h
Merged PRs (30d)
126

Description

FDB uses a shared memory file to generate a random default machine ID, and uses that as the machineid and zoneid in the locality if none are provided explicitly. If both are provided, it still generates the machine ID, but doesn't do anything with it. This is slightly wasteful, and also creates a dependency on shared memory that doesn't exist elsewhere in the system. This could cause problems in environments where shared memory is disabled or misconfigured. Can we defer the generation of the machine ID until it is required?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.