apple / apple/foundationdb

Reduce number of state parameters passed around in data distributor

Open
#3,831 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
16.7k
Forks
1.6k
Avg merge
1d 20h
Merged PRs (30d)
126

Description

Based on discussion of https://github.com/apple/foundationdb/pull/3821, many data distributor functions have a lot of parameters, which harms readability. These parameters can be combined into state classes, and references to this state class can be passed around, reducing the length of function signatures.

Contributor guide

Open the contributing guide

Research direction

Start with the discussion in pull request 3821 and trace the data distributor functions it discusses. Identify which parameter groups can become shared state classes; the work is done when those functions pass the state references instead of long parameter lists while preserving existing behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
database, distributed-systems
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.