apple / apple/foundationdb

reserved identifier violation

Open
#3,744 0 comments 0 reactions 1 assignee Claimed by @sears View on GitHub
Dominant language
C++
Stars
16.7k
Forks
1.6k
Avg merge
1d 20h
Merged PRs (30d)
126

Description

I would like to point out that identifiers like “[`_FDB_FLOW_PROFILER_H_`](https://github.com/apple/foundationdb/blob/4f6054a3e6ff9321de3ff26b39b6151ada83e725/flow/Profiler.h#L21 "Update candidate")” and “[`_FLOW_LOADPLUGIN_H_`](https://github.com/apple/foundationdb/blob/4399480b301b449c48adb6dc12fd930b6188bc4c/fdbrpc/LoadPlugin.h#L21 "Another update candidate")” [do eventually not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for the compiler implementation.") to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.