apple / apple/foundationdb

Remove unnecessary null pointer checks

Open
#3,742 3 comments 0 reactions 1 assignee Claimed by @sfc-gh-mpilman View on GitHub
Dominant language
C++
Stars
16.7k
Forks
1.6k
Avg merge
1d 20h
Merged PRs (30d)
126

Description

[An extra null pointer check is not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following.
- [Writer](https://github.com/apple/foundationdb/blob/dee016f96b624e3970290970b9595fabbcc7c6ba/fdbserver/KeyValueStoreRocksDB.actor.cpp#L55 "Destructor for Writer")
- [MovableCoordinatedState::operator=](https://github.com/apple/foundationdb/blob/f83603e6893a638204fea70aa5453f607fc6f6af/fdbserver/CoordinatedState.actor.cpp#L309 "Assignment operator for MovableCoordinatedState")

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.