apple / apple/foundationdb

Test for commands in backup.actor.cpp

Open
#3,597 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
16.7k
Forks
1.6k
Avg merge
1d 20h
Merged PRs (30d)
126

Description

Backup.actor.cpp is used for many purposes: backupAgent, fdbrestore, fastrestore_tool.

Similar to the lack of good tests for `fdbcli` (e.g., https://github.com/apple/foundationdb/issues/3565), we don't have a good testing story for backup.actor.cpp derived tools. As a result, the command for those tools can be broken silently until someone uses it.

Changing to use special key space framework to replace `fdbcli` can solve `fdbcli` issue, but not backup.actor.cpp issue.

Ideally, fuzz testing for the tool commands will be best.

Contributor guide

Open the contributing guide

Research direction

Start by reading backup.actor.cpp and tracing the command paths used by backupAgent, fdbrestore, and fastrestore_tool. Compare their command coverage with the fdbcli testing gap; done means command behavior is covered by a defined test or fuzz-testing approach so regressions are detected.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
databases, testing
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.