apple / apple/foundationdb

Remove go:nocheckptr pragma in Go bindings

Open
#3,188 0 comments 1 reaction 1 assignee Claimed by @vishesh View on GitHub
Dominant language
C++
Stars
16.7k
Forks
1.6k
Avg merge
1d 20h
Merged PRs (30d)
126

Description

According to @mdempsky, we should be able to remove the pragma by following this advice:

> Nevermind, I see. It's because the struct is packed, so the value field ends up unaligned for a Go pointer.

> I assume these are always pointers into C memory? If so, I think you can change the code to use *uintptr instead of **C.uint8_t, and then you should be able to remove the nocheckptr pragma.

This is related to the changes from #3033

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.