Enable sanity check on backup-metadata file
- Dominant language
- C++
- Stars
- 16.7k
- Forks
- 1.6k
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 126
Description
The sanity check for backup's metadata file, which has not been used, is disabled in PR: https://github.com/apple/foundationdb/pull/3059,
because it magnifies the `TooManyFiles` failure in correctness tests.
Once we resolve the Issue: https://github.com/apple/foundationdb/issues/2766, we should enable the sanity check.
This is not urgent until we start to use the backup's metadata file for speeding up the restore.
Contributor guide
Research direction
Read PR 3059 to find where the backup metadata sanity check was disabled, then review Issue 2766 and the correctness tests that expose the TooManyFiles failure. Once Issue 2766 is resolved, enable the check and verify that correctness tests pass; completion also requires the backup metadata file to support faster restore use.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- databases, distributed-systems
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100