apple / apple/foundationdb

Make crashAndExit defined behavior

Open
#2,785 0 comments 0 reactions 1 assignee Claimed by @sfc-gh-anoyes View on GitHub
Dominant language
C++
Stars
16.7k
Forks
1.6k
Avg merge
1d 20h
Merged PRs (30d)
126

Description

Current `crashAndExit` relies on undefined behavior by creating a segfault. Instead we probably should call `std::abort`.

For this to work properly we also need to change `registerCrashHandler` so that it handles `SIGABRT` correctly.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.