apple / apple/foundationdb

Remove the double logging for open trace file failure from the TraceEvent cache based implementation

Open
#2,739 4 comments 0 reactions 0 assignees View on GitHub
good first issue
Dominant language
C++
Stars
16.7k
Forks
1.6k
Avg merge
1d 20h
Merged PRs (30d)
126

Description

With the new issue reporting mechanism in place (PR #2605), the old TraceEvent cache based implementation specifically for trace file open failure can be removed.

Contributor guide

Open the contributing guide

Research direction

Review PR #2605 first, then search the C++ TraceEvent cache-based implementation for the trace-file-open-failure path. Done means the obsolete cache-based logging is removed without the failure being logged twice; run the relevant existing tests for this path.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
observability-sre
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.