LocalityData constructor does not initialize datahall
Open
- Dominant language
- C++
- Stars
- 16.7k
- Forks
- 1.6k
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 126
Description
https://github.com/apple/foundationdb/blob/master/fdbrpc/Locality.h#L162-L167. `keyDataHallId` does not seem to be initialized. Is this a bug, or intentional design? If intentional, it would be great if there were some comments describing how this is meant to be populated.
Contributor guide
Research direction
Start with the LocalityData constructor and keyDataHallId definition in fdbrpc/Locality.h at lines 162-167. Trace references to keyDataHallId to determine whether its uninitialized state is intentional or a bug. Done means either initializing the field correctly or documenting how and where it is populated.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- distributed-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100