apple / apple/foundationdb

We seem to do eager reads for all keys in storage server, even when not needed

Open
#2,129 2 comments 0 reactions 1 assignee Claimed by @negoyal View on GitHub
Dominant language
C++
Stars
16.7k
Forks
1.6k
Avg merge
1d 20h
Merged PRs (30d)
126

Description

We do eager reads for all keys in relevant mutations (such a atomics, clearRange etc). We do it irrespective of whether we need it or not. In some cases, we may just need to read the versioned map for example.

See this code snippet from update()

for(auto& c : fii.changes)
eager.addMutations(c.mutations);

wait( doEagerReads( data, &eager ) );
if (data->shardChangeCounter == changeCounter) break;

Evaluate whether this should be optimized or there is a reason for it.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.