apple / apple/foundationdb

FDB Should not start on install when cluster file is detected

Open
#2,021 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
16.7k
Forks
1.6k
Avg merge
1d 20h
Merged PRs (30d)
126

Description

https://github.com/apple/foundationdb/blob/85d0dec585b276e3588dfbe6b1c25c07f38a417e/packaging/deb/DEBIAN-foundationdb-server/postinst#L36

It would be preferred to have FDB not start on install when the system detects a pre-existing fdb.cluster or foundationdb.conf file. We often find ourselves adding dozens of processes and/or multiple machines which can be quite disruptive to the cluster depending on current workload.

We are currently maintaining our own version of the debian postinst which skips the start step. However it gets problematic maintaining our own pipeline to change a single file in the deb. We'd like to suggest that FDB should either not start on installation or only start when it detects `$NEWDB == 1`

Contributor guide

Open the contributing guide

Research direction

Start with packaging/deb/DEBIAN-foundationdb-server/postinst at the linked installation step, and inspect how the existing fdb.cluster, foundationdb.conf, and $NEWDB conditions are handled. Done means installation preserves an existing cluster without starting FDB, while still handling a new database according to the selected condition.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell
Domain
build-system
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.