apple / apple/foundationdb

Evaluate TCP_NODELAY vs TCP_QUICKACK

Open
#2,008 2 comments 0 reactions 1 assignee Claimed by @kaomakino View on GitHub
performance
Dominant language
C++
Stars
16.7k
Forks
1.6k
Avg merge
1d 20h
Merged PRs (30d)
126

Description

I have finally learned of the no delay vs quickack argument, and you can see [this explanation](https://www.extrahop.com/company/blog/2016/tcp-nodelay-nagle-quickack-best-practices/) to catch up to where I am now.

Our codebase currently [sets TCP_NODELAY](https://github.com/apple/foundationdb/blob/179ca2cc4a1d67666a0dd2e82ecdf5984e991197/flow/Net2.actor.cpp#L410). It'd be worth running a few tests to see if we observe any difference in setting quickack instead (or both together). I've found some [example code](https://github.com/niklata/nsocks/blob/884e48c199357af987e622975bdad01b6c33752a/socksclient.hpp#L141) for how to set this through boost ASIO.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.