The variable name `existingSessions` is ambiguous since it stores resources, not session objects. Consider renaming to `existingResources` or `existingSessionResources` to better reflect that it tracks URIs/resources rather than session instances.
Open
- Dominant language
- C++
- Stars
- 16.7k
- Forks
- 1.6k
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 126
Description
The variable name `existingSessions` is ambiguous since it stores resources, not session objects. Consider renaming to `existingResources` or `existingSessionResources` to better reflect that it tracks URIs/resources rather than session instances.
_Originally posted by @Copilot in https://github.com/microsoft/vscode/pull/273023#discussion_r2458461964_
Contributor guide
Research direction
Locate the declaration and references to `existingSessions` in the FoundationDB repository; the issue does not name a file or test. Confirm that it stores URIs or resources rather than session instances, rename it consistently to the chosen resource-oriented name, and verify that all references still build and pass the relevant tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- databases, distributed-systems
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100