apple / apple/foundationdb

Fix and improve GRV batching

Open
#1,192 3 comments 1 reaction 0 assignees View on GitHub
Dominant language
C++
Stars
16.7k
Forks
1.6k
Avg merge
1d 20h
Merged PRs (30d)
126

Description

[Forums: How to scale FoundationDB reads](https://forums.foundationdb.org/t/how-to-scale-foundation-db-reads/1108/) has GRV benchmarks and results that show that proxy-side GRV batching seems broken, and that client-side batching is very conservative.

In a sense, this isn't a surprising result, as I'm not aware that we have a GRV benchmark. So we should
1. implement a GRV benchmark for latency at a give throughput, and throughput at a given latency for nightly performance tests. It's also worthwhile to add performance tests that are essentially GRV benchmarks as well: reads per second when one opens a new transaction for each read, and writes/s where one key is written per transaction.
2. Graph GRV latency vs GRV requests/s
3. Improve it

Contributor guide

Open the contributing guide

Research direction

Start with the linked FoundationDB forum benchmarks and the repository's existing nightly performance tests. Define GRV latency at a target throughput, throughput at a target latency, and transaction-level read/write measurements before determining how to graph the results. Done means the benchmarks and graphs exist and GRV batching is improved based on their results.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
databases, distributed-systems, performance
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.