apple / apple/coremltools

Support dilation>1 in max_pool for PyTorch

Open
#1,665 2 comments 0 reactions 0 assignees View on GitHub
PyTorch (traced)
Dominant language
Python
Stars
5.4k
Forks
850
Avg merge
4d 5h
Merged PRs (30d)
10

Description

- Name of layer type: _max_pool (used in max_pool1d, max_pool2d, max_pool3d)
- Is this a PyTorch or a TensorFlow layer type: PyTorch
- Your version of coremltools: 6.0
- Your version of PyTorch/TensorFlow: 1.12.1
- Impact of supporting this layer type. Why is adding support for this layer type important? Is it necessary to support a popular model or use case? Adding dilation to max_pool enables pixel-wise dense prediction in computer vision and model conversions like [Dense Prediction on Sequences with Time-Dilated Convolutions for Speech Recognition](http://arxiv.org/abs/1611.09288) to be implemented

Contributor guide

Open the contributing guide

Research direction

Start at the PyTorch _max_pool conversion entry points used by max_pool1d, max_pool2d, and max_pool3d, and inspect how pooling parameters are handled. Confirm the expected behavior for dilation greater than 1 across these layer types and verify conversion of a model using dilated max pooling.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, pytorch
Domain
machine-learning
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.