apple / apple/container

[Request]: UX: Use stdout and stderr, and logging consistently in CLI commands.

Open
#642 1 comment 0 reactions 0 assignees View on GitHub
next ux
Dominant language
Swift
Stars
49.9k
Forks
1.8k
Avg merge
1d 20h
Merged PRs (30d)
22

Description

### Feature or enhancement request details

Right now some output that should probably go to stderr is just being printed with print().

An example is: https://github.com/apple/container/blob/main/Sources/CLI/System/SystemStart.swift#L95.

All commands should log diagnostics to stderr and print data proper to stdout.

For this we could create a plaintext-to-stderr LogHandler in ContainerClient that all commands use.

At present it appears we do no logging in ContainerClient, with the single Exception of Sources/ContainerClient/ExitMonitor.swift, which is actually only used on the server side. Therefore, we can limit the scope of this to just going through each of the command groups.

### Code of Conduct

- [x] I agree to follow this project's Code of Conduct

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.