apple / apple/container

[Request]: Implement resource identifier validation consistently.

Open
#514 0 comments 0 reactions 0 assignees View on GitHub
ux
Dominant language
Swift
Stars
49.9k
Forks
1.8k
Avg merge
1d 20h
Merged PRs (30d)
22

Description

### Feature or enhancement request details

Resource identifiers are validated inconsistently (some on client, some on server) or not at all (volumes), and allow any length identifier.

We should validate always on the server, limit identifier lengths, and ensure validation patterns are consistent with existing norms.

| Resource | Current validation | Current pattern | Normative (according to Google) |
|-|-|-|-|
| container | client | `[a-zA-Z0-9][a-zA-Z0-9_.-]+` | `[A-Za-z0-9][A-Za-z0-9_-.]{0,62}` |
| image | server | Containerization handles imageref validation properly | lots of rules |
| network | none | N/A | `[a-z0-9][a-z0-9_-]{0,62}` |
| volume | server | `[A-Za-z0-9][A-Za-z0-9_.-]*` | `[a-z0-9][a-z0-9_-]{0,62}` |

### Code of Conduct

- [x] I agree to follow this project's Code of Conduct

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.