apple / apple/app-store-server-library-node

Use jose instead of jsonwebtoken

Open
#318 1 comment 9 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
382
Forks
79
Avg merge
1d 7h
Merged PRs (30d)
9

Description

jsonwebtoken hasn't been updated in two years, and its dependencies, like safe-buffer, are no longer necessary. These dependencies don't support ESM, causing errors when packaging with tools like esbuild.

```shell
> pnpm why safe-buffer
@apple/app-store-server-library 1.6.0
└─┬ jsonwebtoken 9.0.2
└─┬ jws 3.2.2
├─┬ jwa 1.4.2
│ ├─┬ ecdsa-sig-formatter 1.0.11
│ │ └── safe-buffer 5.2.1
│ └── safe-buffer 5.2.1
└── safe-buffer 5.2.1
```

jose supports ESM and has zero dependencies.

Image

Contributor guide

Open the contributing guide

Research direction

The issue names no files or tests; first locate all jsonwebtoken usage and inspect the package configuration and any existing token-signing tests. Compare those call sites with jose's API, then verify the dependency is removed and the library still packages successfully with ESM-oriented tooling.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api, backend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.