appbaseio / appbaseio/reactivesearch

ReactiveComponent re renders custom component within render props

Open
#1,704 1 comment 0 reactions 1 assignee Claimed by @bietkul View on GitHub
bug
Dominant language
JavaScript
Stars
4.9k
Forks
478
PR merge metrics
No merged PRs in 30d

Description

**Affected Projects**
React

**Library Version:** x.y.z
^3.18.1

**Describe the bug**
When utilizing `ReactiveComponent` and rendering a custom component in `render` prop. ReactiveComponent re renders numerous number of times causing performance issues.

**To Reproduce**
https://codesandbox.io/s/reactive-component-re-renders-ynqth?file=/src/index.js
In a small code sandbox implementation, the sandbox console outputs the re rendered value within the render props.

Within a bare bones implementation in production environment the component is rendered more than 200 times.
**Expected behavior**
The component in render props should only be rendered once than multiple times.

**Screenshots**
![image](https://user-images.githubusercontent.com/66189547/120541891-73417300-c3b8-11eb-8e90-110f527ecda0.png)
![image](https://user-images.githubusercontent.com/66189547/120542088-aedc3d00-c3b8-11eb-9f4b-ab18fd74e025.png)

**Desktop (please complete the following information):**
- OS: [Windows 10]
- Browser: [Chrome ]
- Version [90.0.4430.212 ]

**Smartphone (please complete the following information):**
N/A

**Additional context**
N/A

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.