appbaseio / appbaseio/reactivesearch

Validating the number of clauses in DataSearch component

Open
#1,519 5 comments 0 reactions 1 assignee Claimed by @bietkul View on GitHub
bug
Dominant language
JavaScript
Stars
4.9k
Forks
478
PR merge metrics
No merged PRs in 30d

Description

**React**

There's a default ElasticSearch limit of 1024 clauses within a query. Users may reach this limit when pasting a long list of values to search against within the DataSearch component. In my case it crashes ElasticSearch and returns the error "caused_by":{"type":"too_many_clauses","reason":"maxClauseCount is set to 1024"}.

It would be great if there was a way of setting a limit/validating entries once this limit is reached to prevent ElasticSearch from crashing. I'm trying to solve this by using beforeValueChange to reject the entry if it's greater than 1024. But I need to be able to reset the promise and the value the user has entered so they can start again. With the code below, the promise is rejected and the user can no longer edit the input. Any suggestions? Thanks

beforeValueChange={
(value) => {
return new Promise((resolve, reject) => {
if (withinElasticSearchMaxClauseLimit(value)) {
resolve();
} else {
// how do I clear the user entered value and reset the promise here?
reject();
}

})
}
}

function withinElasticSearchMaxClauseLimit(str) {
str = str.replace(/(^\s*)|(\s*$)/gi, "");
str = str.replace(/[ ]{2,}/gi, " ");
str = str.replace(/\n /, "\n");
return str.split(' ').length <= 1024;
}

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.