appbaseio / appbaseio/reactivecore

Suggestion filtering hides synonyms

Open
#29 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
33
Forks
27
PR merge metrics
No merged PRs in 30d

Description

I've enabled synonym support in my elasticsearch, which means, for example, end users might search for "trousers" and get back results that do not contain "trousers" but do contain "pants". I think that [getSuggestions](https://github.com/appbaseio/reactivecore/blob/master/src/utils/suggestions.js#L30) is hiding these results. Have you put any thought into this scenario? I think I understand what the filtering here is trying to do, which is handle when the user has changed their search term by the time results come back ( right? ), but in my case it's hiding results I'd still like to see.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in src/utils/suggestions.js at getSuggestions, linked from the issue, and read the filtering logic that removes results after a search-term change. Reproduce the trousers/pants synonym scenario and determine whether the intended behavior is to retain those results without breaking protection against stale responses. Done means the filtering behavior is clarified and synonym matches are no longer hidden when they are valid suggestions.

Written by the indexing model from the issue text.

Assessment

Tech stack
elasticsearch, javascript
Domain
search
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.