appbaseio / appbaseio/designkit

Button component's theme prop field: textDark

Open
#1 0 comments 0 reactions 0 assignees View on GitHub
bug enhancement
Dominant language
JavaScript
Stars
14
Forks
4
PR merge metrics
No merged PRs in 30d

Description

There is only one prop within button's theme: `textDark`. Which is also not being properly prioritized, i.e. global theme's `textDark` is always set irrespective of what is being set here.

Also the field name `textDark` isn't the most descriptive name. I suggest changing it to `textColor` or supporting a `textLight` field as well.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.