appandflow / appandflow/react-navigation-bottom-sheet

Lack of stackBehavior property

Open
#5 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
496
Forks
24
PR merge metrics
No merged PRs in 30d

Description

Lack of [stackBehavior](https://gorhom.github.io/react-native-bottom-sheet/modal/props/#stackbehavior) property

Here is the diff that solved my problem:

```diff
diff --git a/node_modules/@th3rdwave/react-navigation-bottom-sheet/lib/typescript/types.d.ts b/node_modules/@th3rdwave/react-navigation-bottom-sheet/lib/typescript/types.d.ts
index e03cf4e..d807543 100644
--- a/node_modules/@th3rdwave/react-navigation-bottom-sheet/lib/typescript/types.d.ts
+++ b/node_modules/@th3rdwave/react-navigation-bottom-sheet/lib/typescript/types.d.ts
@@ -31,6 +31,8 @@ export declare type BottomSheetNavigationOptions = Omit
*/
snapPoints?: Array;
+
+ stackBehavior?: 'push' | 'replace'
};
export declare type BottomSheetNavigatorProps = DefaultNavigatorOptions, BottomSheetNavigationOptions, BottomSheetNavigationEventMap> & BottomSheetNavigationConfig;
export declare type BottomSheetDescriptor = Descriptor, RouteProp>;
diff --git a/node_modules/@th3rdwave/react-navigation-bottom-sheet/src/types.tsx b/node_modules/@th3rdwave/react-navigation-bottom-sheet/src/types.tsx
index eb22fea..78af81b 100644
--- a/node_modules/@th3rdwave/react-navigation-bottom-sheet/src/types.tsx
+++ b/node_modules/@th3rdwave/react-navigation-bottom-sheet/src/types.tsx
@@ -89,6 +89,8 @@ export type BottomSheetNavigationOptions = Omit<
* @type Array
*/
snapPoints?: Array;
+
+ stackBehavior?: 'push' | 'replace'
};

export type BottomSheetNavigatorProps = DefaultNavigatorOptions<
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.