appandflow / appandflow/expo-image-cropping

Max height limit

未关闭
#1 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
TypeScript
星标
7
派生
0
PR 合并指标
30 天内没有已合并 PR

描述

Greetings and congratulations for the work.

I have a suggestion, I was testing the package and there is something wrong with the user experience, the cut and/or cancel buttons are on top of the image when the image has a considerable height.

I propose to adjust that using a dimanic hook that detects the height of the screen and

❌:
![Screenshot from 2024-02-24 17-41-32](https://github.com/AppAndFlow/expo-image-cropping/assets/45801428/97f6f585-4461-475e-bc48-a290ad729ab2)

✅:
![Screenshot from 2024-02-24 17-46-18](https://github.com/AppAndFlow/expo-image-cropping/assets/45801428/c5aebc82-33ed-40c3-97cf-33c348dd5441)

Use height property:

```js
const { width, height } = useWindowDimensions();

```
![code](https://github.com/AppAndFlow/expo-image-cropping/assets/45801428/eb228dea-f183-4680-8045-32643c1f73ce)

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。