apostrophecms / apostrophecms/apostrophe

Pages menu tree - moving lower level node to the top most node doesnt seem to fire move event

Open
#2,247 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
4.6k
Forks
650
Avg merge
19h 21m
Merged PRs (30d)
23

Description

## To Reproduce

Step by step instructions to reproduce the behavior:

> 1. Open the pages menu (Reorganize Pages modal)
> 2. Move a lower node above the top most node
> 3. Click finished on modal
> 4. Page refreshes
> 5. Reopen pages menu, no change/save for ordering

## Expected behavior
> When you move a lower level node to the top most node it should save the wanted ordering

## Describe the bug
> It seems that the move event for the top node is not firing when moving a lower level node to the top position in the pages menu tree. The move event does fire if/when you adjust the menu nodes in the opposite fashion.

## Details

**Version of Node.js:**
v8.11.4

**Server Operating System:**
MacOS Mojave

**Screenshots**
Please find a link to a video of the issue I am experiencing with the pages tree movement node movement https://www.loom.com/share/7bca3e9d4a5b4512b7dcaa19b5f6847b

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the issue in the Reorganize Pages modal: move a lower-level node above the topmost node, finish, and reopen the menu. Trace the pages menu tree's move event handling and verify that the new ordering persists after refresh and reopening.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.