apollographql / apollographql/graphql-subscriptions

Bad Definitely Typed definition for Sinon is breaking the build

Open
#186 1 comment 0 reactions 1 assignee Claimed by @grantwwu View on GitHub
bug
Dominant language
TypeScript
Stars
1.6k
Forks
129
PR merge metrics
No merged PRs in 30d

Description

The build is outputting the following error, this is referenced in DefinitelyTyped/DefinitelyTyped#30657

```
node_modules/@types/sinon/index.d.ts:41:20 - error TS2370: A rest parameter must be of an array type.

41 calledWith(...args: TArgs): boolean;
~~~~~~~~~~~~~~
node_modules/@types/sinon/index.d.ts:45:27 - error TS2370: A rest parameter must be of an array type.

45 calledWithExactly(...args: TArgs): boolean;
~~~~~~~~~~~~~~
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.