apollographql / apollographql/graphql-subscriptions
Convert tests to properly await all promises
Open
- Dominant language
- TypeScript
- Stars
- 1.6k
- Forks
- 129
- PR merge metrics
- No merged PRs in 30d
Description
Right now a lot of the tests don't really await promises that they send off; it's better to return promises to mocha, as described in https://wietse.loves.engineering/testing-promises-with-mocha-90df8b7d2e35
This already caused 1 unhandled promise rejection issue, which I recently fixed as part of https://github.com/apollographql/graphql-subscriptions/pull/148.
Contributor guide
Assessment
This issue has not been assessed yet.