apollographql / apollographql/federation
fix(federation): Missing error code
- Dominant language
- TypeScript
- Stars
- 727
- Forks
- 276
- Avg merge
- 1h 47m
- Merged PRs (30d)
- 1
Description
There's no composition error code provided [here](https://github.com/apollographql/federation/blob/0bf5dcee198691d22475914e3626043f4d1729bf/federation-js/src/composition/validate/sdl/uniqueFieldDefinitionNames.ts#L40-L50).
Noticed upon addition of the graphql error serializer in #686 [here](https://github.com/apollographql/federation/pull/686/files#diff-3cd86bb6d92386721dc125b2323ef27753f5052b09abd63c6980b339930610faR414-R421)
Contributor guide
Research direction
Start in federation-js/src/composition/validate/sdl/uniqueFieldDefinitionNames.ts at lines 40-50, then compare the expected error shape with the GraphQL error serializer changes referenced in #686. Add the missing composition error code and verify that this validation error is serialized with it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- graphql, typescript
- Domain
- api, backend-api-design
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100