apollographql / apollographql/federation

gateway constructor ordering issue

Open
#425 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
725
Forks
276
Avg merge
1h 47m
Merged PRs (30d)
1

Description

in apollo gateway constructor, the line `if(config){}` must be set before line `this.schema = this.createSchema`, otherwise this.experimental_didFailComposition will not work for the first time!

Contributor guide

Open the contributing guide

Research direction

Start at the Apollo gateway constructor and inspect the ordering of the config handling and schema creation. Verify that the first composition failure is handled when experimental_didFailComposition is enabled; done means config is processed before createSchema and the first failure behaves correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
graphql, typescript
Domain
api, backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.