apollographql / apollographql/federation

Federation 2.1.2 changes ordering of directives for `@deprecated` fields with `@join__field`

Open
#2,153 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
725
Forks
276
Avg merge
1h 47m
Merged PRs (30d)
1

Description

# Before (federation 2.1.1)
```graphql
type MyType {
myField: Boolean! @deprecated(reason: "...") @join__field(graph: SUBGRAPH)
}
```

# After (federation 2.1.2)
```graphql
type MyType {
myField: Boolean! @join__field(graph: SUBGRAPH) @deprecated(reason: "...")
}
```

___

This was generated with `rover supergraph compose` with `federation_version` set to `2`.

Contributor guide

Open the contributing guide

Research direction

The issue names no source files or tests; start by reproducing the `rover supergraph compose` output with `federation_version` set to `2` and compare Federation 2.1.1 with 2.1.2. Done means the generated GraphQL preserves the expected ordering of `@deprecated` and `@join__field` directives.

Written by the indexing model from the issue text.

Assessment

Tech stack
graphql, typescript
Domain
backend-api-design
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.