apollographql / apollographql/apollo-tooling

apollo-language-server: Include graphql as a peer dependency

Open
#2,652 0 comments 3 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
3k
Forks
460
PR merge metrics
No merged PRs in 30d

Description

**Intended outcome:**

Graphql to be included as a peer dependency in the `apollo-language-server` package, similar to how it's included in the `apollo-graphql` package (https://github.com/apollographql/apollo-tooling/blob/master/packages/apollo-graphql/package.json#L19).

Nice to have: Add support for GraphQL 16.

**Actual outcome:**

Graphql is currently being included as a dependency in the `apollo-language-server` package (https://github.com/apollographql/apollo-tooling/blob/master/packages/apollo-language-server/package.json#L37), and doesn't follow these guidelines: https://leebyron.com/graphql-js-preparing-for-v14/

**Versions**

apollo-language-server: 1.26.9

Contributor guide

Open the contributing guide

Research direction

The package metadata is in packages/apollo-language-server/package.json; compare its graphql entry with packages/apollo-graphql/package.json. Inspect the dependency and peerDependency declarations, then verify the resulting package metadata. Done means graphql is exposed as the intended peer dependency; GraphQL 16 support is an optional follow-up.

Written by the indexing model from the issue text.

Assessment

Tech stack
graphql, typescript
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.